Skip to content

Add test discovery documentation for test addons #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented May 14, 2025

Motivation

Step towards #3421

This PR adds documentation for the test discovery process that add-ons can contribute. I decided to not put command resolution and custom reporters in the same PR because it would make it too long to review.

I also made this a dedicated file under add-ons. It's complex enough that it warrants longer examples with more detailed explanations.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock requested review from alexcrocha and st0012 May 14, 2025 14:33
@vinistock vinistock self-assigned this May 14, 2025
@vinistock vinistock added the documentation Improvements or additions to documentation label May 14, 2025 — with Graphite App
@vinistock vinistock marked this pull request as ready for review May 14, 2025 14:34
@vinistock vinistock requested a review from a team as a code owner May 14, 2025 14:34
@vinistock vinistock force-pushed the 05-14-add_test_discovery_documentation_for_test_addons branch from 05af426 to 17855b5 Compare May 14, 2025 14:35
Copy link
Contributor

@alexcrocha alexcrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪
Added a couple suggestions and a few nits.

@vinistock vinistock force-pushed the 05-14-add_test_discovery_documentation_for_test_addons branch from 17855b5 to 796903a Compare May 21, 2025 16:57
@vinistock vinistock enabled auto-merge (squash) May 21, 2025 17:23
@vinistock vinistock merged commit 167189e into main May 21, 2025
44 checks passed
@vinistock vinistock deleted the 05-14-add_test_discovery_documentation_for_test_addons branch May 21, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants